Horton

Re: GIN predicate locking slows down valgrind isolationtests tremendously

Alexander Korotkov <a.korotkov@postgrespro.ru>

View thread View on postgr.es
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Teodor Sigaev <teodor@sigaev.ru>, Shubham Barai <shubhambaraiss@gmail.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2018-12-25T01:32:49Z
Lists: pgsql-hackers

Attachments

On Tue, Dec 25, 2018 at 12:19 AM Alexander Korotkov
<a.korotkov@postgrespro.ru> wrote:
> So, we're checking for conflict on tree root for every entry insert.
> That's right for posting tree, but completely unneeded for entry tree.
> I'm intended to change that to lock root of only posting tree if
> nobody explains me why I'm wrong...

BTW, I've tried to remove conflict checking from entry tree root
(patch is attached).  Neither current or my version of isolation tests
appear to be affected.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Reduce length of GIN predicate locking isolation test suite

  2. Remove entry tree root conflict checking from GIN predicate locking