Horton

Re: Fortify float4 and float8 regression tests by ordering test results

Alexander Korotkov <aekorotkov@gmail.com>

View thread
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-22T16:22:10Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid depending on post-UPDATE row order in float4/float8 tests.

On Tue, Apr 22, 2025 at 7:20 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
> > I'd like to add that float4.out not only assumes that insert-ordering is
> > preserved (this could be more-or-less portable between table AMs).  It also
> > assumes the way UPDATE moves updated rows.  That seems quite
> > heap-specific.  You can see in the following fragment, updated rows jump to
> > the bottom.
>
> I'd be willing to consider a policy that we don't want to depend on
> exactly where UPDATE moves rows to.  The proposed patch is not that,
> however.

OK, that makes sense for me.

------
Regards,
Alexander Korotkov
Supabase