Horton

Re: gist microvacuum doesn't appear to care about hot standby?

Alexander Korotkov <a.korotkov@postgrespro.ru>

View thread View on postgr.es
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Teodor Sigaev <teodor@sigaev.ru>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Date: 2018-12-16T22:03:52Z
Lists: pgsql-hackers

Attachments

On Thu, Dec 13, 2018 at 7:28 AM Alexander Korotkov
<a.korotkov@postgrespro.ru> wrote:
> On Thu, Dec 13, 2018 at 1:45 AM Andres Freund <andres@anarazel.de> wrote:
> > Is there any reason something like that isn't necessary for gist? If so,
> > where's that documented? If not, uh, isn't that a somewhat serious bug
> > in gist?
>
> Thank you for pointing!  This looks like a bug for me too.  I'm going
> to investigate more on this and provide a fix in next couple of days.

Sorry for delay.  Attached patch implements conflict handling for gist
microvacuum like btree and hash.  I'm going to push it if no
objections.

Note, that it implements new WAL record type.  So, new WAL can\t be
replayed on old minor release.  I'm note sure if we claim that it's
usually possible.  Should we state something explicitly for this case?

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Convert gist to compute page level xid horizon on primary.

  2. Compute XID horizon for page level index vacuum on primary.

  3. Check for conflicting queries during replay of gistvacuumpage()

  4. Microvacuum for GIST