Re: Allow placeholders in ALTER ROLE w/o superuser

Alexander Korotkov <aekorotkov@gmail.com>

From: Alexander Korotkov <aekorotkov@gmail.com>

To: Steve Chavez <steve@supabase.io>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, nathandbossart@gmail.com, pgsql-hackers@postgresql.org

Date: 2022-12-01T03:14:37Z

Lists: pgsql-hackers

Attachments

0001-ALTER-ROLE-.-SET-.-TO-.-USER-SET-v2.patch (application/octet-stream) patch v2-0001

On Wed, Nov 23, 2022 at 1:53 AM Steve Chavez <steve@supabase.io> wrote:
> So from my side this all looks good!

Thank you for your feedback.

The next revision of the patch is attached.  It contains code
improvements, comments and documentation.  I'm going to also write
sode tests.  pg_db_role_setting doesn't seem to be well-covered with
tests.  I will probably need to write a new module into
src/tests/modules to check now placeholders interacts with dynamically
defined GUCs.

------
Regards,
Alexander Korotkov

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove extra regress check arguments from test_pg_db_role_setting
- 529da086ba7f 16.0 landed
meson: Add 'running' test setup, as a replacement for installcheck
- afdd9f7f0e00 16.0 landed
Add USER SET parameter values for pg_db_role_setting
- 096dd80f3ccc 16.0 landed
Fix sloppy cleanup of roles in privileges.sql.
- b62303794efd 16.0 cited
Drop test user when done with it.
- f31111bbe81d 12.0 cited
GRANT rights to CURRENT_USER instead of adding roles
- 6928484bda45 9.6.0 cited
Clean up roles from roleattributes test
- 072710dff3ee 9.6.0 cited
Make repeated 'make installcheck' runs work
- b22b77068380 9.5.0 cited