Re: Get rid of WALBufMappingLock
Alexander Korotkov <aekorotkov@gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Noah Misch <noah@leadboat.com>
Cc: Yura Sokolov <y.sokolov@postgrespro.ru>, Tomas Vondra <tomas@vondra.me>, Michael Paquier <michael@paquier.xyz>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-06T22:48:06Z
Lists: pgsql-hackers
On Sat, Jul 5, 2025 at 7:16 AM Noah Misch <noah@leadboat.com> wrote:
>
> On Mon, Mar 31, 2025 at 09:18:30PM +0300, Alexander Korotkov wrote:
> > I'm going to push the first patch ("nowalbuf") if no objections.
>
> I completed a post-commit review of this patch. I think the patch is correct.
Great. I'm glad to hear that.
> I found some of the variable names and comments challenging, so I made the
> attached local edits in the course of the review. I don't know whether my
> choices are better or just tailored to my biases. If someone thinks this
> would improve the tree, I can polish this and commit it. Absent that,
> consider these notes to myself and to other post-commit reviewers.
I took a look to these edits. They look good to me.
------
Regards,
Alexander Korotkov
Supabase