Re: Inherited UPDATE/DELETE vs async execution
Etsuro Fujita <etsuro.fujita@gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-13T11:10:52Z
Lists: pgsql-hackers
On Thu, May 13, 2021 at 5:00 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote: > > On Thu, May 13, 2021 at 3:32 PM Amit Langote <amitlangote09@gmail.com> wrote: > > On Wed, May 12, 2021 at 6:45 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote: > > > Here is a rebased version of the patch. I'm planning to apply this tommorow. > > > > + /* > > + * Finally, unset the async-capable flag if it is set. > > + */ > > > > Would it make sense to expand here even just a bit on why we must do this? > > +1 How about something like this? > > "Finally, unset the async-capable flag if it is set, as we currently > don't support asynchronous execution of direct modifications." Pushed after modifying the comment as such. I think we could improve it later. :-) Thanks for the comment! Will close this in the open items list. Best regards, Etsuro Fujita
Commits
-
Prevent asynchronous execution of direct foreign-table modifications.
- a784859f4480 14.0 landed