Horton

Re: Fixing memory leaks in postgres_fdw

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-05-31T11:29:10Z
Lists: pgsql-hackers 
On Fri, May 30, 2025 at 2:02 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Finally, here's a minimalistic version of the original v1-0001
> patch that I think we could safely apply to fix the DirectModify
> problem in the back branches.  I rejiggered it to not depend on
> inventing MemoryContextUnregisterResetCallback, so that there's
> not hazards of minor-version skew between postgres_fdw and the
> main backend.

Seems reasonable.

Thanks for updating the patch (and pushing it in all supported versions)!

Best regards,
Etsuro Fujita

Commits

  1. Silence leakage complaint about postgres_fdw's InitPgFdwOptions.

  2. Run pgindent on the changes of the previous patch.

  3. Reap the benefits of not having to avoid leaking PGresults.

  4. Create infrastructure to reliably prevent leakage of PGresults.

  5. Fix memory leakage in postgres_fdw's DirectModify code path.

  6. Avoid resource leaks when a dblink connection fails.