Horton
Menu

Re: Bug: trailing comma syntax error in postgres_fdw fetch_attstats()

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-21T10:50:59Z
Lists: pgsql-hackers 
On Sun, Apr 12, 2026 at 3:40 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Sun, Apr 12, 2026 at 10:45 AM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> > When importing statistics from a remote server running PostgreSQL < 17,
> > fetch_attstats() emits three NULL placeholders for the range statistics
> > columns that don't exist on older servers.  The string literal included a trailing
> > comma after the last NULL, producing invalid SQL:
> >
> >     SELECT ... NULL, NULL, NULL, FROM pg_catalog.pg_stats ...
> >
> > This fails ANALYZE or IMPORT STATISTICS on a foreign table backed
> > by a pre-v17 remote server with a syntax error.
>
> My bad, I will take care of this.

The patch looks good to me.  I will push it if there are no objections.

Best regards,
Etsuro Fujita

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. postgres_fdw: Fix syntax error in fetch_attstats().