Horton

Re: BUG #16631: postgres_fdw tries to insert into generated columns

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: dacherny@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2021-07-07T09:35:09Z
Lists: pgsql-bugs 
On Wed, Jul 7, 2021 at 5:45 PM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
> On 07.07.21 09:20, Etsuro Fujita wrote:
> > * Modified nodeModifyTable.c and copyfrom.c so that they don't compute
> > generated columns for FDWs anymore.
>
> I don't agree with that change.  What is the point of declaring a
> generated column on a foreign table if you ignore it?  Then you might as
> well prohibit declaring such columns in the first place.

I made that change as FDWs could call ExecComputeStoredGenerated() by
themselves if necessary.  I think that that would be consistent with
the constraint case.

Best regards,
Etsuro Fujita

Commits

  1. postgres_fdw: Fix issues with generated columns in foreign tables.