Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Etsuro Fujita <etsuro.fujita@gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Gilles Darold <gilles@darold.net>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-06T11:13:10Z
Lists: pgsql-hackers
Hi Michael-san, On Wed, Nov 6, 2019 at 4:35 PM Michael Paquier <michael@paquier.xyz> wrote: > On Wed, Nov 06, 2019 at 03:12:04PM +0900, Etsuro Fujita wrote: > > On Wed, Nov 6, 2019 at 1:13 PM Michael Paquier <michael@paquier.xyz> wrote: > >> "postgres_fdw foreign tables" sounds weird to me. Could "foreign > >> tables using postgres_fdw" be a better wording? I am wondering as > >> well if we should not split this information into two parts: one for > >> the actual error message which only mentions foreign tables, and a > >> second one with a hint to mention that postgres_fdw has been used. > > > > We use "postgres_fdw foreign tables" or "postgres_fdw tables" in > > release notes, so I thought it was OK to use that in error messages as > > well. But actually, these wordings are not suitable for error > > messages? > > It is true that the docs of postgres_fdw use that and that it is used > in some comments. Still, I found this wording a bit weird.. If you > think that what you have is better, I am also fine to let you have the > final word, so please feel to ignore me :) I'd like to hear the opinions of others. Best regards, Etsuro Fujita
Commits
-
Add regression test for two-phase transaction in postgres_fdw
- 94fec48516a7 13.0 landed
-
postgres_fdw: Fix error message for PREPARE TRANSACTION.
- 1bd67d535843 9.4.25 landed
- b260ce9c19b6 9.5.20 landed
- bca0aed2d01c 9.6.16 landed
- 0c7a28a5eabd 10.11 landed
- 042e82cef949 11.6 landed
- 0cc31cc32da0 12.1 landed
- 879c11761571 13.0 landed