Horton

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jeevan Ladhe <jeevanladhe.os@gmail.com>
Date: 2022-05-30T06:27:42Z
Lists: pgsql-hackers 
Amit-san,

On Fri, May 27, 2022 at 9:22 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >  Attached is a patch for that.

> I think we should also rewrite the description to match the CREATE
> TABLE's text, as in the attached updated patch.

Actually, I thought the description would be OK as-is, because it says
“See the similar form of CREATE TABLE for more details”, but I agree
with you; it’s much better to also rewrite the description as you
suggest.

I’ll commit the patch unless Robert wants to.

Thanks for the review and patch!

Best regards,
Etsuro Fujita

Commits

  1. Doc: Further fix CREATE FOREIGN TABLE synopsis.

  2. In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.