Re: Asynchronous MergeAppend

Etsuro Fujita <etsuro.fujita@gmail.com>

From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, Matheus Alcantara <matheusssilv97@gmail.com>, Alexander Pyhalov <a.pyhalov@postgrespro.ru>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2026-04-07T10:25:41Z
Lists: pgsql-hackers
On Tue, Apr 7, 2026 at 9:25 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> Thank you for your feedback.  I would say that this patch is here for
> quite long, and it's pretty straightforward.  It passed many rounds of
> review by Matheus Alcantara.  I've done a lot of minor cleanups and
> improvements, and reorganized changes into multiple patches.  The only
> major change I did is actually a simplification which come from the
> fact that only initial heap filling is effectively async [1].  Today
> Matheus gave a feedback on my changes.

I think Matheus did a good job, but he said "I still don't have too
much experience with the executor code but I hope that I can help with
something.", and IIUC, his reviews were mostly about code
cleanup/deduplication, so ISTM that the patch hadn't been reviewed
that extensively, despite its complexity.  That was actually one of
the reasons why I lowered the priority of the patch.

> Surely, I wouldn't commit this patch without giving you a chance to
> review.  We can postpone it till early PG20 development cycle.  But if
> you find it possible to take a look at this patch during Apr 7, let me
> know.

Sorry, I don't have time for that.  I will defer to your judgment, too.

Thank all of you for working on this important feature, anyway!

Best regards,
Etsuro Fujita



Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Handle interrupts while waiting on Append's async subplans