Horton

Re: BEFORE UPDATE trigger on postgres_fdw table not work

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Tom Lane <tgl@sss.pgh.pa.us>, Shohei Mochizuki <shohei.mochizuki@toshiba.co.jp>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-06-12T07:30:26Z
Lists: pgsql-hackers 
Amit-san,

On Wed, Jun 12, 2019 at 3:33 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > * Reworded the comments a bit in postgresPlanFoereignModify the
> > original patch modified
>
> +     * statement, and for UPDATE if BEFORE ROW UPDATE triggers since those
> +     * triggers might change values for non-target columns, in which case we
>
> First line seems to be missing a word or two.  Maybe:
>
> +     * statement, and for UPDATE if there are BEFORE ROW UPDATE triggers,
> +     * since those triggers might change values for non-target columns, in

Actually, I omitted such words to shorten the comment, but I think
this improves the readability, so I'll update the comment that way.

Thanks for the review!

Best regards,
Etsuro Fujita

Commits

  1. postgres_fdw: Account for triggers in non-direct remote UPDATE planning.

  2. Offer triggers on foreign tables.