Re: BEFORE UPDATE trigger on postgres_fdw table not work

Etsuro Fujita <etsuro.fujita@gmail.com>

From: Etsuro Fujita <etsuro.fujita@gmail.com>

To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Shohei Mochizuki <shohei.mochizuki@toshiba.co.jp>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2019-06-12T06:13:56Z

Lists: pgsql-hackers

Attachments

fix_fdw_update_trigger-efujita.patch (application/octet-stream) patch

On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> I'll look into the patch more closely tomorrow.

I did that, but couldn't find any issue about the patch.  Here is an
updated version of the patch.  Changes are:

* Reworded the comments a bit in postgresPlanFoereignModify the
original patch modified
* Added the commit message

Does that make sense?  I think this is an oversight in commit
7cbe57c34, so I'll back-patch all the way back to 9.4, if there are no
objections.

Best regards,
Etsuro Fujita

Commits

postgres_fdw: Account for triggers in non-direct remote UPDATE planning.
- 1a3d9f62c1d1 9.4.23 landed
- eddb79705f65 9.5.18 landed
- 1ade21e7facc 9.6.14 landed
- 0f2b234263ef 10.9 landed
- 214460182161 11.4 landed
- 8b6da83d162c 12.0 landed
Offer triggers on foreign tables.
- 7cbe57c34dec 9.4.0 cited