Horton
Menu

Re: Thinko in pgstat_build_snapshot()

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-06T11:35:23Z
Lists: pgsql-hackers 
On Sun, Mar 30, 2025 at 10:47 PM Gurjeet Singh <gurjeet@singh.im> wrote:
> On Sun, Mar 30, 2025 at 4:31 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> > On 30/03/2025 13:23, Etsuro Fujita wrote:
> > > While working on something else I noticed $SUBJECT: we are allocating
> > > more memory than necessary and copying more data than necessary
> > > because we specify the wrong PgStat_KindInfo member as the size
> > > argument for MemoryContextAlloc and memcpy.  This could become
> > > problematic if snapshotting a very large number of variables stats, so
> > > I fixed it.  Attached is a patch for that.
> >
> > Good catch. Patch looks good to me at quick glance.
>
> +1 on both counts.

I will push the patch as well.

Thank you both for looking at the patch!

Best regards,
Etsuro Fujita

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix memory allocation/copy mistakes.