Horton

Re: Problem with transition tables on partitioned tables with foreign-table partitions

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-08T09:17:35Z
Lists: pgsql-hackers 
On Mon, Jul 14, 2025 at 8:00 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> After re-reading the patch I noticed two minor things:
>
> * The existing code in ExecAR* functions already dereferences the
> passed-in ResultRelInfo pointer without checking that it is not NULL.
> The Assert I added to those functions would be an overkill, so I
> removed it.  Sorry for the back and forth.
>
> * I added a trigger function trigger_nothing() in the regression
> tests, but I noticed an existing trigger function above the tests.  To
> make the tests a bit small, I replaced trigger_nothing() with the
> existing trigger function and removed trigger_nothing().
>
> Attached is a new version of the patch.

I have pushed this and back-patched it to all supported versions.

Best regards,
Etsuro Fujita

Commits

  1. Disallow collecting transition tuples from child foreign tables.