Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Etsuro Fujita <etsuro.fujita@gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
Gilles Darold <gilles@darold.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-08T08:19:34Z
Lists: pgsql-hackers
Hi Michael-san, On Fri, Nov 8, 2019 at 9:10 AM Michael Paquier <michael@paquier.xyz> wrote: > On Thu, Nov 07, 2019 at 06:40:36PM +0900, Etsuro Fujita wrote: > > On Thu, Nov 7, 2019 at 5:28 PM Kyotaro Horiguchi > > <horikyota.ntt@gmail.com> wrote: > >> At Thu, 7 Nov 2019 17:20:07 +0900, Etsuro Fujita <etsuro.fujita@gmail.com> wrote in > >>> Only two people complaining about the wording? Considering as well > > That's like.. Half the folks participating to this thread ;) Right... > >>> that we use that wording in the docs and there were no complains about > >>> that IIRC, I don't feel a need to change that, TBH. > >> But the most > >> significant point in the previous mail is using "foreign tables using > >> postgres_fdw" instead of "postgres_fdw foreign tables". > > > > OK, but as I said above, I don't feel the need to change that. How > > about leaving it for another patch to improve the wording in that > > message and/or the documentation if we really need to do it. > > Fine by me. If I were to put a number on that, I would be around +-0, > so I don't have an actual objection with your point of view either. OK, pushed as-is. Thanks for reviewing! Best regards, Etsuro Fujita
Commits
-
Add regression test for two-phase transaction in postgres_fdw
- 94fec48516a7 13.0 landed
-
postgres_fdw: Fix error message for PREPARE TRANSACTION.
- 1bd67d535843 9.4.25 landed
- b260ce9c19b6 9.5.20 landed
- bca0aed2d01c 9.6.16 landed
- 0c7a28a5eabd 10.11 landed
- 042e82cef949 11.6 landed
- 0cc31cc32da0 12.1 landed
- 879c11761571 13.0 landed