Re: postgres_fdw: incomplete subabort cleanup of connections used in async execution

Etsuro Fujita <etsuro.fujita@gmail.com>

From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-22T05:40:45Z
Lists: pgsql-hackers
Hi Alexander,

On Wed, Dec 22, 2021 at 1:08 AM Alexander Pyhalov
<a.pyhalov@postgrespro.ru> wrote:
> Etsuro Fujita писал 2021-12-19 13:25:
> > While working on [1], I noticed $SUBJECT: postgres_fdw resets the
> > per-connection states of connections, which store async requests sent
> > to remote servers in async_capable mode, during post-abort
> > (pgfdw_xact_callback()), but it fails to do so during post-subabort
> > (pgfdw_subxact_callback()).  This causes a crash when re-executing a
> > query that was aborted in a subtransaction:

> Looks good to me.

Great!  Thanks for reviewing!

Best regards,
Etsuro Fujita



Commits

  1. postgres_fdw: Fix subabort cleanup of connections used in asynchronous execution.

  2. Add support for asynchronous execution.