Horton
Menu

Thinko in pgstat_build_snapshot()

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-30T10:23:29Z
Lists: pgsql-hackers

Attachments

While working on something else I noticed $SUBJECT: we are allocating
more memory than necessary and copying more data than necessary
because we specify the wrong PgStat_KindInfo member as the size
argument for MemoryContextAlloc and memcpy.  This could become
problematic if snapshotting a very large number of variables stats, so
I fixed it.  Attached is a patch for that.

Best regards,
Etsuro Fujita

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix memory allocation/copy mistakes.