Horton

Re: BUG #17355: Server crashes on ExecReScanForeignScan in postgres_fdw when accessing foreign partition

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2022-02-04T00:56:42Z
Lists: pgsql-bugs 
On Thu, Feb 3, 2022 at 7:37 PM Marina Polyakova
<m.polyakova@postgrespro.ru> wrote:
> Looks like gcc 11.2.0 is now reporting a warning in the branches
> master/REL_14_STABLE, e.g. see CI
> https://github.com/postgres/postgres/runs/5047720839:
>
> [06:30:18.201] nodeForeignscan.c: In function ‘ForeignNext’:
> [06:30:18.201] nodeForeignscan.c:47:13: error: unused variable ‘estate’
> [-Werror=unused-variable]
> [06:30:18.201]    47 |  EState    *estate = node->ss.ps.state;
> [06:30:18.201]       |             ^~~~~~
>
> Please could you fix it?

Sorry, my oversight.  Andres fixed this independently.

Thanks for the report!

Best regards,
Etsuro Fujita

Commits

  1. Further fix for EvalPlanQual with mix of local and foreign partitions.

  2. Fix segfault during EvalPlanQual with mix of local and foreign partitions.

  3. Rework planning and execution of UPDATE and DELETE.