Horton

Re: [PATCH] Fix column name escaping in postgres_fdw stats import

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Zhenwei Shang <a934172442@gmail.com>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>, Alex Guo <guo.alex.hengchen@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, efujita@postgresql.org
Date: 2026-05-14T08:47:17Z
Lists: pgsql-hackers 
On Wed, May 13, 2026 at 8:22 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Wed, May 13, 2026 at 4:27 PM Zhenwei Shang <a934172442@gmail.com> wrote:
> > The patch overall looks solid to me. A tiny suggestion, while here, would it make sense to also add comma and brace column names to the test, as they are classic array-literal hazards, like “col,comma” and “col{brace”?

> Those cases are handled correctly even without the patch, so sorry, I
> don't feel the need to extend the test further.

Pushed.  I didn't extend the test, but I think we could do so later if needed.

I closed the entry in the PG20-1 CF as well as the open item.

Best regards,
Etsuro Fujita