Thread

Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

Etsuro Fujita <etsuro.fujita@gmail.com> — 2025-09-25T10:55:44Z

On Thu, Sep 25, 2025 at 8:15 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Sep 24, 2025 at 09:45:26AM -0700, Masahiko Sawada wrote:
> > On Wed, Sep 24, 2025 at 3:28 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >> I took a quick glance at the patch.  My initial comment is: it only
> >> includes the test case discussed here, but I think it's a good idea to
> >> add more cases in it (that exercise code paths in
> >> postgresRecheckForeignScan), as I mentioned upthread.  What do you
> >> think about that?  If no objections, I'd like to update it to include
> >> such cases.
> >
> > +1 to add more test cases for the code paths in postgresRecheckForeignScan.
>
> +1.  Would these be included in the same isolation test?  That may be
> cleaner, especially as it seems like the EPQ re-evaluations should be
> able to happen with the same schema as the one set up by the test.

Yes, I will add those cases to the same isolation test, as you mentioned.

Best regards,
Etsuro Fujita