Re: problem with RETURNING and update row movement
Etsuro Fujita <etsuro.fujita@gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-09-24T10:30:42Z
Lists: pgsql-hackers
On Thu, Sep 24, 2020 at 2:47 PM Amit Langote <amitlangote09@gmail.com> wrote: > On Thu, Sep 24, 2020 at 4:25 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote: > BTW, the discussion so far on the other thread is oblivious to the > issue being discussed here, where we need to find a way to transfer > system attributes between a pair of partitions that are possibly > incompatible with each other in terms of what set of system attributes > they support. Yeah, we should discuss the two issues together. > Although, if we prevent accessing system attributes > when performing the operation on partitioned tables, like what you > seem to propose below, then we wouldn't really have that problem. Yeah, I think so. > > Yeah, but for the other issue, I started thinking that we should just > > forbid referencing xmin/xmax/cmin/cmax in 12, 13, and HEAD... > > When the command is being performed on a partitioned table you mean? Yes. One concern about that is triggers: IIUC, triggers on a partition as-is can or can not reference xmin/xmax/cmin/cmax depending on whether a dedicated tuple slot for the partition is used or not. We should do something about this if we go in that direction? > That is, it'd be okay to reference them when the command is being > performed directly on a leaf partition, although it's another thing > whether the leaf partitions themselves have sensible values to provide > for them. I think so too. Best regards, Etsuro Fujita
Commits
-
Fix bugs in RETURNING in cross-partition UPDATE cases.
- a71cfc56bf60 13.3 landed
- 3fb93103a9fd 12.7 landed
- 27835b547664 11.12 landed
-
postgres_fdw: Clean up handling of system columns.
- da7d44b627ba 9.6.0 cited