Re: postgres_fdw fails because GMT != UTC
Etsuro Fujita <etsuro.fujita@gmail.com>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2024-04-10T11:30:59Z
Lists: pgsql-hackers
On Thu, Apr 4, 2024 at 3:49 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote: > On Thu, 2024-04-04 at 02:19 -0400, Tom Lane wrote: > > > ERROR: invalid value for parameter "TimeZone": "UTC" > > > > I am not quite clear on how broken an installation needs to be to > > reject "UTC" as a time zone setting, except that the breakage cannot > > be subtle. However, I notice that our code in pgtz.c and other > > places treats "GMT" as a hard-wired special case ... but not "UTC". > > I wonder if we ought to modify those places to force "UTC" down the > > same hard-wired paths. If we acted like that, this would have worked > > no matter how misconfigured the installation was. > > > > An alternative answer could be to change postgres_fdw to send "GMT" > > not "UTC". That's ugly from a standards-compliance viewpoint, but > > it would fix this problem even with a non-updated remote server, > > and I think postgres_fdw is generally intended to work with even > > very old remote servers. > > > > Or we could do both. > > I think the first is desirable for reasons of general sanity, and the > second for best compatibility with old versions. > > So I vote for "both". +1 for both (assuming that the latter does not make the postgres_fdw code complicated). Best regards, Etsuro Fujita
Commits
-
Make postgres_fdw request remote time zone 'GMT' not 'UTC'.
- ce1c30eceb57 12.19 landed
- a3021aafcecb 17.0 landed
- 75929b6cfaff 16.3 landed
- 6c85e3359be0 15.7 landed
- 3ed6e1698521 14.12 landed
- 0e56b2b9447b 13.15 landed