Re: [PATCH] Fix column name escaping in postgres_fdw stats import

Etsuro Fujita <etsuro.fujita@gmail.com>

From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: Alex Guo <guo.alex.hengchen@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, efujita@postgresql.org
Date: 2026-05-12T07:36:12Z
Lists: pgsql-hackers

Attachments

Hi Ayush,

On Mon, May 4, 2026 at 7:24 AM Ayush Tiwari <ayushtiwari.slg01@gmail.com> wrote:
> Are there some edits you would like me to make on the patch?

One thing I noticed is the test case you added; it only tests
departing column names with single quotes, but it's better to also
test that with backslashes, to confirm the patch addresses the issue
in [1] as well.  So I updated the patch as such.  New version
attached.  Other than that the patch looks good to me, so I'll push it
if no objections from you (or anyone else).

> Or would you like me to add the thread link to open items for 19?

I added this thread to an existing open item as the second report.

Sorry for the delay.

Best regards,
Etsuro Fujita

[1] https://www.postgresql.org/message-id/CAHg%2BQDc9%3DWtYi%3DJW6QUL6ASOJc6PcGPTuxoMkhnkQ7oi7j5atg%40mail.gmail.com