Horton

Comment in portal.h

Etsuro Fujita <etsuro.fujita@gmail.com>

View thread View on postgr.es
From: Etsuro Fujita <etsuro.fujita@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-07-30T10:39:27Z
Lists: pgsql-hackers

Attachments

Hi,

I noticed $SUBJECT while working on something else:

    /*
     * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
     * PORTAL_UTIL_SELECT query.  (A cursor held past the end of its
     * transaction no longer has any active executor state.)
     */
    Tuplestorestate *holdStore; /* store for holdable cursors */
    MemoryContext holdContext;  /* memory containing holdStore */

We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
"Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.".  Attached is a
patch for that.

Best regards,
Etsuro Fujita

Commits

  1. Update comment in portal.h.