Thread

Re: Obsolete comments in ResultRelInfo struct

Etsuro Fujita <etsuro.fujita@gmail.com> — 2025-08-12T10:21:55Z

Hi,

On Tue, Aug 12, 2025 at 2:03 AM Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> On Mon, 11 Aug 2025 at 12:25, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >
> >     /*
> >      * Other information needed by child result relations
> >      *
> >      * RootResultRelInfo gives the target relation mentioned in the query.
> >      * Used as the root for tuple routing and/or transition capture.
> >      *
> >      * PartitionTupleSlot is non-NULL if the relation is a partition to route
> >      * tuples into and RootToChild conversion is needed.
> >      */
>
> That seems reasonable.

Cool!

> I think it's also worth adding the "ri_" prefix
> to the field names in those comments.

+1, so I created a patch incorporating your proposal, which I am attaching.

Thanks for the comment!

Best regards,
Etsuro Fujita