Re: Extra Vietnamese unaccent rules

Man <man.trieu@gmail.com>

From: Man Trieu <man.trieu@gmail.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Dang Minh Huong <kakalot49@gmail.com>, Thomas Munro <thomas.munro@enterprisedb.com>, Kha Nguyen <nlhkha@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-06-06T16:06:22Z
Lists: pgsql-hackers

Attachments

2017-06-07 0:31 GMT+09:00 Bruce Momjian <bruce@momjian.us>:

> On Wed, Jun  7, 2017 at 12:10:25AM +0900, Dang Minh Huong wrote:
> > > On Jun 4, 29 Heisei, at 00:48, Bruce Momjian <bruce@momjian.us> wrote:
> > >>>> Shouldn't you use "or is_letter_with_marks()", instead of "or
> len(...)
> > >>>>> 1"?  Your test might catch something that isn't based on a 'letter'
> > >>>> (according to is_plain_letter).  Otherwise this looks pretty good to
> > >>>> me.  Please add it to the next commitfest.
> > >>>
> > >>> Thanks for confirm, sir.
> > >>> I will add it to the next CF soon.
> > >>
> > >> Sorry for lately response. I attach the update patch.
> > >
> > > Uh, there is no patch attached.
> > >
> >
> > Sorry sir, reattach the patch.
> > I also added it to the next CF and set reviewers to Thomas Munro. Could
> you confirm for me.
>
> There seems to be a problem.  I can't see a patch dated 2017-06-07 on
> the commitfest page:
>
>         https://commitfest.postgresql.org/14/1161/
>
> I added the thread but there was no change.  (I think the thread was
> already present.)  It appears it is not seeing this patch as the latest
> patch.
>
> Does anyone know why this is happening?
>


May be due to my Mac's mailer? Sorry but I try one more time to attach the
patch by webmail.

---
Thanks and best regards,
Dang Minh Huong

Commits

  1. Extend the default rules file for contrib/unaccent with Vietnamese letters.