Re: dropdb --force
Filip Rembiałkowski <filip.rembialkowski@gmail.com>
From: Filip Rembiałkowski <filip.rembialkowski@gmail.com>
To: Marti Raudsepp <marti@juffo.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-05T09:51:58Z
Lists: pgsql-hackers
Attachments
- drop-database-force-20190305_01.patch (text/x-patch) patch
Here is Pavel's patch rebased to master branch, added the dropdb --force option, a test case & documentation. I'm willing to work on it if needed. What are possible bad things that could happen here? Is the documentation clear enough? Thanks. On Tue, Dec 18, 2018 at 4:34 PM Marti Raudsepp <marti@juffo.org> wrote: > > Hi > > > út 18. 12. 2018 v 16:11 odesílatel Filip Rembiałkowski <filip.rembialkowski@gmail.com> napsal: > >> Please share opinions if this makes sense at all, and has any chance > >> going upstream. > > Clearly since Pavel has another implementation of the same concept, > there is some interest in this feature. :) > > On Tue, Dec 18, 2018 at 5:20 PM Pavel Stehule <pavel.stehule@gmail.com> wrote: > > Still one my customer use a patch that implement FORCE on SQL level. It is necessary under higher load when is not easy to synchronize clients. > > I think Filip's approach of setting pg_database.datallowconn='false' > is pretty clever to avoid the synchronization problem. But it's also a > good idea to expose this functionality via DROP DATABASE in SQL, like > Pavel's patch, not just the 'dropdb' binary. > > If this is to be accepted into PostgreSQL core, I think the two > approaches should be combined on the server side. > > Regards, > Marti Raudsepp
Commits
-
Add tests for '-f' option in dropdb utility.
- 8a7e9e9dad56 13.0 landed
-
Move pump_until to TestLib.pm.
- 290acac92b1d 13.0 landed
-
Add the support for '-f' option in dropdb utility.
- 80e05a088e4e 13.0 landed
-
Introduce the 'force' option for the Drop Database command.
- 1379fd537f9f 13.0 landed
-
Improve CREATE/DROP/RENAME DATABASE so that when failing because the source
- 4abd7b49f1e9 8.4.0 cited