Thread

1. Improve coments on structures in trigger.c

   Yugo Nagata <nagata@sraoss.co.jp> — 2025-03-31T06:24:15Z

   Hi,
   
   I found that comments in trigger.c describing fields of three different
   structures in a comment block. I feel this is confusing because some
   structure names are not explicitly mentioned there even though common field
   names are used between structures. I've attached a patch to improve the comments
   by splitting it to three blocks.
   
   Regards,
   Yugo Nagata
   
   -- 
   Yugo Nagata <nagata@sraoss.co.jp>
   

2. Re: Improve coments on structures in trigger.c

   Philip Alger <paalger0@gmail.com> — 2025-10-06T02:38:21Z

   Hi Yugo,
   
   
   > I found that comments in trigger.c describing fields of three different
   > structures in a comment block.
   
   
   That makes sense to me.
   
   
   > I've attached a patch to improve the comments
   > by splitting it to three blocks.
   >
   
   I think you could also move the comment beginning on:
   
       * AfterTriggersData has the following fields:
   
   To between:
   
     typedef struct AfterTriggersTableData AfterTriggersTableData;
   > HERE
       typedef struct AfterTriggersData
   
   To keep it consistent with the other comments you moved around.