Re: [PATCH] Add min/max aggregate functions to BYTEA

Marat Bukharov <marat.buharov@gmail.com>

From: Marat Bukharov <marat.buharov@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@postgresql.org, David Rowley <dgrowleyml@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-10-08T18:12:22Z
Lists: pgsql-hackers
Thank you for the corrections. I was busy recently and did not follow
conversations in the mailing list. Sorry about that.

--

With best regards,
Marat Bukharov

вт, 8 окт. 2024 г. в 17:24, Aleksander Alekseev <aleksander@timescale.com>:
>
> Hi,
>
> > I just glanced over this patch. Are you still planning on working on
> > it? There's been no adjustments made since the last feedback you got
> > in early August.
> >
> > Can you address Andrey's feedback on point #1?
> >
> > Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
> > been done in record_larger() and record_smaller() except use
> > byteacmp(). That'll remove all the duplicated code.
> >
> > If you fix those up, I see no reason not to commit the patch.
>
> Since we haven't heard from Marat since July I decided to rebase the
> patch and address the feedback received so far. PFA patch v6.
>
> --
> Best regards,
> Aleksander Alekseev



Commits

  1. Add min and max aggregates for bytea type.