Re: Stack-based tracking of per-node WAL/buffer usage

Lukas Fittl <lukas@fittl.com>

From: Lukas Fittl <lukas@fittl.com>

To: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Cc: Zsolt Parragi <zsolt.parragi@percona.com>, Tomas Vondra <tomas@vondra.me>, Peter Smith <smithpb2250@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>

Date: 2026-04-04T09:43:50Z

Lists: pgsql-hackers

Attachments

v12-0002-instrumentation-Separate-per-node-logic-from-oth.patch (application/x-patch) patch v12-0002
v12-0005-Optimize-measuring-WAL-buffer-usage-through-stac.patch (application/x-patch) patch v12-0005
v12-0001-instrumentation-Separate-trigger-logic-from-othe.patch (application/x-patch) patch v12-0001
v12-0003-instrumentation-Replace-direct-changes-of-pgBuff.patch (application/x-patch) patch v12-0003
v12-0004-instrumentation-Add-additional-regression-tests-.patch (application/x-patch) patch v12-0004
v12-0006-instrumentation-Use-Instrumentation-struct-for-p.patch (application/x-patch) patch v12-0006
v12-0009-Add-test_session_buffer_usage-test-module.patch (application/x-patch) patch v12-0009
v12-0007-instrumentation-Optimize-ExecProcNodeInstr-instr.patch (application/x-patch) patch v12-0007
v12-0008-Index-scans-Show-table-buffer-accesses-separatel.patch (application/x-patch) patch v12-0008

Hi,

Attached v12, rebased, otherwise no changes.

I realize time to freeze is getting close, and whilst I'd love to see
this go in, I'm also realistic - so I'll just do my best to support
review in the off chance we can make it for this release.

On that note, I think 0001 and 0002 are independently useful
refactorings to split the different kinds of instrumentation that
should be ready to go, and I don't think should conflict much with
other patches in this commitfest.

Thanks,
Lukas

--
Lukas Fittl

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

instrumentation: Allocate query level instrumentation in ExecutorStart
- 2c16deee2f7d 19 (unreleased) landed
instrumentation: Move ExecProcNodeInstr to allow inlining
- 544000288ec8 19 (unreleased) landed
instrumentation: Separate per-node logic from other uses
- 5a79e78501f4 19 (unreleased) landed
instrumentation: Separate trigger logic from other uses
- 7d9b74df53e9 19 (unreleased) landed
instrumentation: Rename INSTR_TIME_LT macro to INSTR_TIME_GT
- 3218825271bd 19 (unreleased) landed
instrumentation: Keep time fields as instrtime, convert in callers
- e5a5e0a90750 19 (unreleased) landed