Horton

Re: Small and unaffected typo in pg_logical_slot_get_changes_guts()

Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>

View thread View on postgr.es
From: Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-16T04:25:09Z
Lists: pgsql-hackers

Attachments

Hi !

2022年2月16日(水) 11:42 Michael Paquier <michael@paquier.xyz>:
>
> On Wed, Feb 16, 2022 at 11:27:58AM +0900, Kasahara Tatsuhito wrote:
> > Since commit dd04e958c8b03c0f0512497651678c7816af3198,
> > tuplestore_donestoring() seems to be left only for compatibility, so
> > it looks like it can be removed from the core code, except for the
> > header (tuplestore.h).
>
> FWIW, it looks sensible to me to just do the cleanup you are
> suggesting here on HEAD, aka keeping the compatibility macro in the
> header, but wiping out any references of it in the C code.  That
> reduces the chances of copy-pasting it around for no effect.  Would
> you like to write a patch?
Thanks for the reply. The patch is attached.
Remove all references to tuplestore_donestoring() except for the header.

Best regards,

-- 
Tatsuhito Kasahara
kasahara.tatsuhito _at_ gmail.com

Commits

  1. Remove all traces of tuplestore_donestoring() in the C code

  2. tuplestore_donestoring() isn't needed anymore, but provide a no-op