Re: Add mode column to pg_stat_progress_vacuum
Shinya Kato <shinya11.kato@gmail.com>
From: Shinya Kato <shinya11.kato@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
Nathan Bossart <nathandbossart@gmail.com>, Robert Treat <rob@xzilla.net>, pgsql-hackers@postgresql.org
Date: 2025-10-09T12:04:20Z
Lists: pgsql-hackers
On Wed, Oct 8, 2025 at 4:40 AM Sami Imseih <samimseih@gmail.com> wrote: > > > > I wonder if we could be even more granular > > > for the "normal autovacuum" case and point to the reason the table was > > > chosen. For example, was it the insert threshold, the update/delete > > > threshold, etc.? > > > > Sounds like reasonable information. I guess we might want to have such > > information in a cumulative statistics view but do you think it's > > better to have it in a dynamic statistics view? > > +1 for this information in cumulative stats, on a per table level for sure. > I do think however the pg_stat_all_tables views is getting too wide > and moving new relation vacuum stats to a separate stats view will > be very useful. Thanks for the discussion. IIUC are you suggesting I add such a last_autovacuum_reason column to pg_stat_all_tables, which would be populated with one of the following values? - autovacuum_vacuum_threshold - autovacuum_vacuum_insert_threshold - autovacuum_freeze_max_age - autovacuum_multixact_freeze_max_age (For consistency, I should probably add a last_autoanalyze_reason column to pg_stat_all_tables as well.) -- Best regards, Shinya Kato NTT OSS Center