Horton

Re: file_fdw: Support multi-line HEADER option.

Shinya Kato <shinya11.kato@gmail.com>

View thread View on postgr.es
From: Shinya Kato <shinya11.kato@gmail.com>
To: songjinzhou <tsinghualucky912@foxmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-01-15T07:14:35Z
Lists: pgsql-hackers 
On Fri, Jan 9, 2026 at 9:51 PM songjinzhou <tsinghualucky912@foxmail.com> wrote:
> I tested the patch and have no functional questions. I have a small question: Is it necessary to add "(also as a string, to support file_fdw options)" to the final `ereport` error message in `defCheckCopyHeaderString`? Like in one of your comments below.

Thank you for reviewing my patch and the comment!

I don’t think we should add “(also as a string, to support file_fdw
options)” to the ereport message because PostgreSQL error messages
typically describe the semantic type rather than the input format.

For instance, REJECT_LIMIT accepts a string in file_fdw but the error
message simply asks for a numeric value.


-- 
Best regards,
Shinya Kato
NTT OSS Center

Commits

  1. file_fdw: Support multi-line HEADER option.

  2. Improve the error message in COPY with HEADER option.

  3. Support multi-line headers in COPY FROM command.