Thread

Re: Add mode column to pg_stat_progress_vacuum

Shinya Kato <shinya11.kato@gmail.com> — 2025-10-09T11:31:57Z

On Wed, Oct 8, 2025 at 12:04 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> > I was able to manually verify the failsafe mode's behavior by using
> > the existing test script at
> > src/test/modules/xid_wraparound/t/001_emergency_vacuum.pl. This script
> > successfully triggered the failsafe condition and the view reported
> > the correct mode. However, I found this test to be somewhat flaky in
> > my environment and decided not to add it to the patch to avoid
> > introducing a potentially unstable test into the tree.
>
> Perhaps there's something we can do with injection points to improve the
> stability of the test.

Thank you for the advice. You're right, I can test it with injection
point. However, many other progress reporting views do not have
regression tests, so I do not have to add a regression test of
pg_stat_progress_report.




--
Best regards,
Shinya Kato
NTT OSS Center