Re: Add mode column to pg_stat_progress_vacuum

Shinya Kato <shinya11.kato@gmail.com>

From: Shinya Kato <shinya11.kato@gmail.com>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Sami Imseih <samimseih@gmail.com>, Robert Treat <rob@xzilla.net>, maciek@sakrejda.org, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-12-05T04:29:54Z

Lists: pgsql-hackers

Attachments

v9-0001-Add-mode-and-started_by-columns-to-pg_stat_progre.patch (application/octet-stream)
v9-0002-Add-started_by-column-to-pg_stat_progress_analyze.patch (application/octet-stream)

Thank you for the review!

On Thu, Dec 4, 2025 at 9:15 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> I've attached a small change to simplify the 0001 patch. Please review it.

LGTM, and I've updated in v9 patches.

> Here are a few comments:
>
> +        <listitem>
> +         <para>
> +          <literal>manual</literal>: The analyze was started by an explicit
>
> For consistency with "started_by" in pg_stat_progress_vacuum, I think
> it's better to start with "The operation was started by".

I think "started_by" in pg_stat_progress_vacuum uses "The vacuum was
started by ...".

> ---
> +          <command>ANALYZE</command> or <command>VACUUM (ANALYZE)</command>
> +          command.
>
> How about using "... or VACUUM with the ANALYZE option"?

Agreed, I've fixed it.


-- 
Best regards,
Shinya Kato
NTT OSS Center