Re: Logical Replication of sequences

Shinya Kato <shinya11.kato@gmail.com>

From: Shinya Kato <shinya11.kato@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Chao Li <li.evan.chao@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, shveta malik <shveta.malik@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Jonathan S. Katz" <jkatz@postgresql.org>

Date: 2025-11-06T02:29:31Z

Lists: pgsql-hackers

Attachments

fix-logical-sequence-sync-quoted-names.diff (application/octet-stream)

On Wed, Nov 5, 2025 at 5:28 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> I have pushed the 0001 after making minor adjustments in tests and at
> a few other places. Kindly rebase and send the remaining patches.

I discovered that the sequence sync worker fails for sequences
containing single quotes.
---
2025-11-06 10:22:50.335 JST [1096008] ERROR:  could not fetch sequence
information from the publisher: ERROR:  syntax error at or near
"quote"
        LINE 4: FROM ( VALUES ('public', 'regress'quote', 0), ('public', 'ho...
                                                  ^
2025-11-06 10:22:50.335 JST [1088168] LOG:  background worker "logical
replication sequencesync worker" (PID 1096008) exited with exit code 1
---

I haven't read all the threads, so I might be mistaken, but I've
created a patch.


-- 
Best regards,
Shinya Kato
NTT OSS Center