Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-11-16T18:57:15Z
Lists: pgsql-hackers
Greetings, On Tue, Nov 16, 2021 at 13:16 Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > On 2021-Nov-16, Stephen Frost wrote: > > > Not against possibly changing that but I don’t get the point of including > > be-gssapi-common.h if it’s not enabled in the build and typically if > GSSAPI > > is possible and the reason for including be-gssapi-common.h then there’s > > other things that need to be under a ifdef, again, as in auth.c > > BTW, this is exactly why my first suggestion was to add an exclusion > rule to headerscheck so that be-gssapi-common.h is not verified by that > script. After re-reading your response, that looks like a reasonable > answer too. Yeah, that seems better to me, though I’ve not yet had time to look deeply into any of this. Thanks, Stephen >
Commits
-
Harden be-gssapi-common.h for headerscheck
- f76fd05bae04 13.6 landed
- f744519326e1 15.0 landed
- 733f2be094aa 12.10 landed
- 1b1e4bfe7da7 14.2 landed
-
Fix headerscheck failure in replication/worker_internal.h
- ad26ee28250c 15.0 cited