Re: [PATCH] Include application_name in "connection authorized" log message

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>
To: Don Seiler <don@seiler.us>
Cc: Gilles Darold <gilles.darold@dalibo.com>, pgsql-hackers@lists.postgresql.org
Date: 2018-06-25T20:32:05Z
Lists: pgsql-hackers
Greetings

On Mon, Jun 25, 2018 at 15:57 Don Seiler <don@seiler.us> wrote:

> On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold <gilles.darold@dalibo.com>
> wrote:
>
>> I would prefer the following output to conform to elog.c output:
>>
>>     2018-06-25 17:32:46.854 CEST [23265] LOG:  connection authorized:
>> user=postgres database=postgres application=[unknown]
>>
> Hello Gilles,
>
> The different cases were for Stephen's request earlier in this thread. I'm
> happy to write it either way and agree it would be nice to not have a lot
> of duplicate code. Do you want me to submit another patch?
>

I think it’s better to not change the line when application name isn’t
being set, as the latest patch has. That also matches how we handle the SSL
info- it’s only shown if ssl is in place on the connection.

Thanks!

Stephen

>

Commits

  1. Add application_name to connection authorized msg