Horton
Menu

Re: Add mode column to pg_stat_progress_vacuum

Maciek Sakrejda <m.sakrejda@gmail.com>

View thread
From: Maciek Sakrejda <m.sakrejda@gmail.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, Robert Treat <rob@xzilla.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-11-19T07:56:24Z
Lists: pgsql-hackers 
On Tue, Nov 18, 2025, 21:10 Shinya Kato <shinya11.kato@gmail.com> wrote:

> On Wed, Nov 19, 2025 at 9:04 AM Masahiko Sawada
> <sawada.mshk@gmail.com> > > Fixed, but I have a comment. I noticed
> minor wording inconsistencies,
> > > e.g., 'started' vs. 'initiated' and 'due to' vs. 'because of'. Should
> > > I unify these terms?
> >
> > +1
>
> It seems the inconsistency between 'started' and 'initiated' has not
> been resolved. Come to think of it, since the column name is
> triggerd_by, I think it would be best to standardize on 'triggered'. I
> have attached a patch to fix this.


I'm late to the discussion, but have you considered just "trigger" for the
column name? It's shorter and just as clear.

In any case, thanks for working on and reviewing this—it's a handy addition!

Thanks,
Maciek

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add started_by column to pg_stat_progress_analyze view.

  2. Add mode and started_by columns to pg_stat_progress_vacuum view.