Re: warn if GUC set to an invalid shared library
Maciek Sakrejda <m.sakrejda@gmail.com>
From: Maciek Sakrejda <m.sakrejda@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-08T21:32:53Z
Lists: pgsql-hackers
On Thu, Dec 30, 2021 at 12:21 AM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote: > Overall the idea looks good to me. A warning on ALTER SYSTEM SET seems > reasonable than nothing. ERROR isn't the way to go as it limits the > users of setting the extensions in shared_preload_libraries first, > installing them later. Is NOTICE here a better idea than WARNING? I don't think so--I'm skeptical that "updated shared_preload_libraries first, then install them" is much more than a theoretical use case. We may not want to block that off completely, but I think a warning is reasonable here, because you're *probably* doing something wrong if you get to this message at all (and if you're not, you're probably familiar enough with Postgres to know to ignore the warning). Thanks, Maciek