Horton

Re: concerns around pg_lsn

Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>

View thread View on postgr.es
From: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2019-08-01T07:09:26Z
Lists: pgsql-hackers

Attachments

Hi Michael,

> I will further check if by mistake any further commits have removed
> > references to assignments from float8in_internal_opt_error(),
> > evaluate it, and set out a patch.
>
> Thanks, Jeevan!
>

Here is a patch that takes care of addressing the flag issue including
pg_lsn_in_internal() and others.

I have further also fixed couple of other functions,
numeric_div_opt_error() and
numeric_mod_opt_error() which are basically callers of
make_result_opt_error().

Kindly do let me know if you have any comments.

Regards,
Jeevan Ladhe

Commits

  1. Add safeguards in LSN, numeric and float calculation for custom errors

  2. Don't call data type input functions in GUC check hooks