Re: Optimise default partition scanning while adding new partition

Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>

View thread View on postgr.es

From: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>

To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>

Date: 2017-09-14T08:03:52Z

Lists: pgsql-hackers

Attachments

0001-Check-default-partitition-child-validation-scan-is.patch (application/octet-stream) patch 0001

Thanks Amit for reviewing.

Patch looks fine to me.  By the way, why don't we just say "Can we skip
> scanning part_rel?" in the comment before the newly added call to
> PartConstraintImpliedByRelConstraint()?  We don't need to repeat the
> explanation of what it does at the every place we call it.
>

I have changed the comment.
PFA.

Regards,
Jeevan Ladhe

Commits

Synchronize error messages.
- ad4a7ed0996e 11.0 landed
On CREATE TABLE, consider skipping validation of subpartitions.
- 6476b26115f3 11.0 landed
On attach, consider skipping validation of subpartitions individually.
- 14f67a8ee282 11.0 landed
Improve error message when skipping scan of default partition.
- c31e9d4bafd8 11.0 landed
Allow a partitioned table to have a default partition.
- 6f6b99d1335b 11.0 cited