Horton

Re: refactoring basebackup.c

Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>

View thread
From: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, tushar <tushar.ahuja@enterprisedb.com>
Date: 2021-11-22T17:35:51Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Document BaseBackupSync and BaseBackupWrite wait events.

  2. Support long distance matching for zstd compression

  3. Fix possible NULL-pointer-deference in backup_compression.c.

  4. Allow parallel zstd compression when taking a base backup.

  5. Make PostgreSQL::Test::Cluster::run_log() return a useful value.

  6. Fix a few goofs in new backup compression code.

  7. Replace BASE_BACKUP COMPRESSION_LEVEL option with COMPRESSION_DETAIL.

  8. Add 'basebackup_to_shell' contrib module.

  9. Allow extensions to add new backup targets.

  10. Change HAVE_LIBLZ4 and HAVE_LIBZSTD tests to USE_LZ4 and USE_ZSTD.

  11. pg_basebackup: Clean up some bogus file extension tests.

  12. pg_basebackup: Avoid unclean failure with server-compression and -D -.

  13. Fix LZ4 tests for remaining buffer space.

  14. Add support for zstd base backup compression.

  15. pg_basebackup: Allow client-side LZ4 (de)compression.

  16. Add suport for server-side LZ4 base backup compression.

  17. Add min() and max() aggregates for xid8.

  18. Remove superfluous variable.

  19. pg_basebackup: Cleaner handling when compression is multiply specified.

  20. Allow server-side compression to be used with -Fp.

  21. pg_basebackup: Fix a couple of recently-introduced bugs.

  22. Tidy up a few cosmetic issues related to pg_basebackup.

  23. Server-side gzip compression.

  24. Unbreak pg_basebackup/t/010_pg_basebackup.pl on msys

  25. Suppress variable-set-but-not-used warning from clang 13.

  26. Extend the options of pg_basebackup to control compression

  27. Support base backup targets.

  28. Modify pg_basebackup to use a new COPY subprotocol for base backups.

  29. Document that tar archives are now properly terminated.

  30. Fix thinko in bbsink_throttle_manifest_contents.

  31. Have the server properly terminate tar archives.

  32. Minimal fix for unterminated tar archive problem.

  33. Introduce 'bbstreamer' abstraction to modularize pg_basebackup.

  34. Introduce 'bbsink' abstraction to modularize base backup code.

  35. Refactor basebackup.c's _tarWriteDir() function.

  36. Flexible options for CREATE_REPLICATION_SLOT.

  37. Flexible options for BASE_BACKUP.

Attachments

Hi Robert,

Please find the lz4 compression patch here that basically has:

1. Documentation
2. pgindent run over it.
3. your comments addressed for using "+="

I have not included the compression level per your comment below:
---------
> "On second thought, maybe we don't need to do this. There's a thread on
> "Teach pg_receivewal to use lz4 compression" which concluded that
> supporting different compression levels was unnecessary."
---------

Regards,
Jeevan Ladhe

On Wed, Nov 17, 2021 at 3:17 AM Robert Haas <robertmhaas@gmail.com> wrote:

> On Mon, Nov 15, 2021 at 2:23 PM Robert Haas <robertmhaas@gmail.com> wrote:
> > Yeah, that's what it should be doing. I'll commit a fix, thanks for
> > the report and diagnosis.
>
> Here's a new patch set.
>
> 0001 - When I committed the patch to add the missing 2 blocks of zero
> bytes to the tar archives generated by the server, I failed to adjust
> the documentation. So 0001 does that. This is the only new patch in
> the series. I was not sure whether to just remove the statement from
> the documentation saying that those blocks aren't included, or whether
> to mention that we used to include them and no longer do. I went for
> the latter; opinions welcome.
>
> 0002 - This adds a new COPY subprotocol for taking base backups. I've
> improved it over the previous version by adding documentation. I'm
> still seeking comments on the points I raised in
>
> http://postgr.es/m/CA+TgmobrOXbDh+hCzzVkD3weV3R-QRy3SPa=FRb_Rv9wF5iPJw@mail.gmail.com
> but what I'm leaning toward doing is committing the patch as is and
> then submitting - or maybe several patches - later to rip some this
> and a few other old things out. That way the debate - or lack thereof
> - about what to do here doesn't have to block the main patch set, and
> also, it feels safer to make removing the existing stuff a separate
> effort rather than doing it now.
>
> 0003 - This adds "server" and "blackhole" as backup targets. In this
> version, I've improved the documentation. Also, the previous version
> only let you use a backup target with -Xnone, and I realized that was
> stupid. -Xfetch is OK too. -Xstream still doesn't work, since that's
> implemented via client-side logic. I think this still needs some work
> to be committable, like adding tests, but I don't expect to make any
> major changes.
>
> 0004 - Server-side gzip compression. Similar level of maturity to 0003.
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>