Horton

Re: concerns around pg_lsn

Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>

View thread View on postgr.es
From: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL Developers <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2019-08-05T03:45:02Z
Lists: pgsql-hackers

Attachments

On Sun, Aug 4, 2019 at 12:13 PM Michael Paquier <michael@paquier.xyz> wrote:

> On Sat, Aug 03, 2019 at 11:57:01PM -0400, Alvaro Herrera wrote:
> > Can we please change the macro definition so that have_error is one of
> > the arguments?  Having the variable be used inside the macro definition
> > but not appear literally in the call is quite confusing.
>

Can't agree more. This is where I also got confused initially and thought
the flag is unused.

Good idea.  This needs some changes only in float.c.


Please find attached patch with the changes to RETURN_ERROR and
it's references in float.c

Regards,
Jeevan Ladhe

Commits

  1. Add safeguards in LSN, numeric and float calculation for custom errors

  2. Don't call data type input functions in GUC check hooks