Re: [PATCH] Fix missing comma in Requires.private with a Make macro

Jacob Champion <jacob.champion@enterprisedb.com>

From: Jacob Champion <jacob.champion@enterprisedb.com>

To: fabriziomello@gmail.com

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Wolfgang Walther <walther@technowledgy.de>

Date: 2025-05-07T19:50:12Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

oauth: Correct missing comma in Requires.private
- a8f093234d78 18.0 landed

On Wed, May 7, 2025 at 11:55 AM Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> LGTM

Thanks for the review!

>> Tested with GNU Make 3.81 (the compilation of which was slightly
>> painful; does anyone want to debate pulling that minimum version up
>> sometime soon?) and 4.3.
>
> Not sure if all animals have a minimum 4.3 make version. Do you?

Oh, I doubt that very much. I don't immediately see the Make version
in the configure logs for the animals, but lapwing for example is
running Debian Wheezy.

--Jacob