Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

Jacob Champion <jacob.champion@enterprisedb.com>

From: Jacob Champion <jacob.champion@enterprisedb.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Euler Taveira <euler.taveira@enterprisedb.com>

Date: 2025-02-10T19:05:32Z

Lists: pgsql-hackers

Attachments

since-v7.diff.txt (text/plain)
v8-0001-pgstat-report-in-earlier-with-STATE_STARTING.patch (application/octet-stream) patch v8-0001
v8-0002-Report-external-auth-calls-as-wait-events.patch (application/octet-stream) patch v8-0002
v8-0003-squash-Report-external-auth-calls-as-wait-events.patch (application/octet-stream) patch v8-0003

On Mon, Feb 10, 2025 at 8:23 AM Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
> The test is supposed to enforce that, but I see that it's not for some
> reason. That's concerning. I'll investigate, thanks for pointing it
> out.

Bad regex escaping on my part; fixed in v8. Thanks for the report!

While debugging, I also noticed that a poorly timed autovacuum could
also show up in my new pg_stat_activity query, so I've increased the
specificity.

> Do we _want_ nine separate flavors of WAIT_EVENT_LDAP_UNBIND? I
> figured it was enough to know that you were stuck unbinding.

v8-0003 shows this approach. For the record, I think it's materially
worse than v7-0003. IMO it increases the cognitive load for very
little benefit and makes it more work for a newcomer to refactor the
cleanup code for those routines. I think it's enough that you can see
a separate LOG message for each failure case, if you want to know why
we're unbinding.

Thanks,
--Jacob

Commits

Fix race condition in TAP test 007_pre_auth
- e2080261cc8c 18.0 landed
Split pgstat_bestart() into three different routines
- c76db55c9085 18.0 landed
backport: Extend background_psql() to be able to start asynchronously
- 6af51bf05a6a 13.21 landed
- 7c07ab62aeb7 14.18 landed
- c0bc11aebb01 15.13 landed
- 6ab58d506bba 16.9 landed
- 49b6f4a02b23 17.5 landed
backport: Improve handling of empty query results in BackgroundPsql
- 3c562b58c20e 13.21 landed
- 3170aece14b8 14.18 landed
- f4b08ccb4ec8 15.13 landed
- fbfd38662f72 16.9 landed
- 31a242e90c88 17.5 landed
Improve handling of empty query results in BackgroundPsql::query()
- 70291a3c66ec 18.0 landed
Extend Cluster.pm's background_psql() to be able to start asynchronously
- ba08edb06545 18.0 landed
dblink: Replace WAIT_EVENT_EXTENSION with custom wait events
- c789f0f6cc5d 17.0 cited