Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

Jacob Champion <jacob.champion@enterprisedb.com>

From: Jacob Champion <jacob.champion@enterprisedb.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Ryo Kanbayashi <kanbayashi.dev@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-03-04T22:26:47Z
Lists: pgsql-hackers
On Mon, Mar 3, 2025 at 10:02 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> I've pushed the patch. Thanks!

Hi all,

> +tests += {
> +  'name': 'ecpg',
> +  'sd': meson.current_source_dir(),
> +  'bd': meson.current_build_dir(),
> +  'tap': {
> +    'tests': [
> +      't/001_ecpg_err_warn_msg.pl',
> +      't/002_ecpg_err_warn_msg_informix.pl',
> +    ],
> +    'deps': ecpg_exe,
> +  },
> +}

My version of Meson is complaining about this use of 'deps':

    ../meson.build:3603: WARNING: Project targets '>=0.54' but uses
feature introduced in '0.60.0': list.<plus>. The right hand operand
was not a list.
    Adding test "ecpg/001_ecpg_err_warn_msg"
    ...

ecpg_exe should perhaps be wrapped in a list for now? I.e.

    -    'deps': ecpg_exe,
    +    'deps': [ecpg_exe],

Thanks,
--Jacob



Commits

  1. ecpg: Fix compiler warning in ecpg build with Meson.

  2. ecpg: Add TAP test for the ecpg command.

  3. Avoid updating inactive_since for invalid replication slots.