Horton

Re: [PoC] Federated Authn/z with OAUTHBEARER

Jacob Champion <jacob.champion@enterprisedb.com>

View thread
From: Jacob Champion <jacob.champion@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter@eisentraut.org>, Christoph Berg <myon@debian.org>, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Thomas Munro <thomas.munro@gmail.com>, Nazir Bilal Yavuz <byavuz81@gmail.com>, Antonin Houska <ah@cybertec.at>
Date: 2025-04-07T17:32:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. meson: Fix install-quiet after clean

  2. oauth: Run Autoconf tests with correct compiler flags

  3. Link libpq with libdl if the platform needs that.

  4. Doc: correct spelling of meson switch.

  5. oauth: Correct SSL dependency for libpq-oauth.a

  6. oauth: Fix Autoconf build on macOS

  7. oauth: Move the builtin flow into a separate module

  8. Remove a stray "pgrminclude" annotation

  9. oauth: Simplify copy of PGoauthBearerRequest

  10. oauth: Improve validator docs on interruptibility

  11. oauth: Disallow synchronous DNS in libcurl

  12. oauth: Fix postcondition for set_timer on macOS

  13. oauth: Use IPv4-only issuer in oauth_validator tests

  14. Work around OAuth/EVFILT_TIMER quirk on NetBSD.

  15. oauth: Fix incorrect const markers in struct

  16. Add missing entry to oauth_validator test .gitignore

  17. cirrus: Temporarily fix libcurl link error

  18. Add support for OAUTHBEARER SASL mechanism

  19. libpq: Handle asynchronous actions during SASL

  20. require_auth: prepare for multiple SASL mechanisms

  21. Move PG_MAX_AUTH_TOKEN_LENGTH to libpq/auth.h

  22. Make SASL max message length configurable

  23. jsonapi: fully initialize dummy lexer

  24. common/jsonapi: support libpq as a client

  25. Remove fe_memutils from libpgcommon_shlib

  26. Revert ECPG's use of pnstrdup()

  27. Explicitly require password for SCRAM exchange

  28. Refactor SASL exchange to return tri-state status

On Mon, Apr 7, 2025 at 10:05 AM Andres Freund <andres@anarazel.de> wrote:
> On 2025-04-07 09:41:25 -0700, Jacob Champion wrote:
> > Ah, you mean if the RPATH'd build doesn't have a flow, but the
> > globally installed one (with a different ABI) does? Yeah, that would
> > be a problem.
>
> That and more: Even if the RPATH libpq does have oauth support, the
> libpq-oauth won't necessarily be at the front of the global library search
> path.  So afaict you'll often get a different libpq-oauth.

ldopen() should respect RPATH, though? Either way, I agree with
pushing the minor version into the name (or else deciding that we will
keep the ABI completely stable across minor version bumps; not sure I
want to guarantee that just yet).

> > We can do it however we want, honestly, especially since the ABI isn't
> > public/stable. I chose this way just to ease review.
>
> I found it rather confusing that libpq looks up a symbol and then sets
> libpq-oauth's symbol to a pointer in libpq's namespace.

Yeah, I think a one-time init call would make this nicer.

> > A future simplification could be to pull the use of the threadlock
> > back into libpq, and have it perform a one-time
> > dlopen-plus-Curl-initialization under the lock... That would also get
> > rid of the dlerror() thread safety problems. But that's an awful lot
> > of moving parts under a mutex, which makes me a little nervous.
>
> I still think we should simply reject at configure time if curl init isn't
> threadsafe ;)

Practically speaking, I don't think that's a choice we can make. For
example, RHEL won't have threadsafe Curl until 10.

> > Could you explain how this is related to .app bundles? I thought I was
> > just building a standard dylib.
>
> The other kind of bundles (what on earth apple was thinking with the naming
> here I don't know). Stuff liked with ld -bundle.

Ah, some new corner-case magic to learn...

> These days we use compiler flags
> that restrict function visibility of everything not annotated with
> PGDLLEXPORT.

Hm, I missed/forgot that. That is nice. Personally I like having a
single file document the exports, so I'll keep it that way for now
unless there are objections, but it's good to know it's not necessary.

Thanks,
--Jacob